From dc69034125f8bfc5afa25c5ea4400be9252516be Mon Sep 17 00:00:00 2001 From: sienori Date: Sat, 23 Feb 2019 17:42:46 +0900 Subject: [PATCH] Add options of display position offset --- src/_locales/en/messages.json | 3 +++ src/content/components/TranslateButton.js | 2 +- src/content/components/TranslatePanel.js | 2 +- src/settings/defaultSettings.js | 20 +++++++++++++++++++- 4 files changed, 24 insertions(+), 3 deletions(-) diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json index 6d22658..4416410 100644 --- a/src/_locales/en/messages.json +++ b/src/_locales/en/messages.json @@ -151,6 +151,9 @@ "rightLabel": { "message": "Right" }, + "positionOffsetLabel": { + "message": "Display position - Offset" + }, "panelStyleLabel": { "message": "Translation panel" }, diff --git a/src/content/components/TranslateButton.js b/src/content/components/TranslateButton.js index 6ee1d35..0be03e2 100644 --- a/src/content/components/TranslateButton.js +++ b/src/content/components/TranslateButton.js @@ -4,7 +4,7 @@ import "../styles/TranslateButton.scss"; const calcPosition = () => { const buttonSize = parseInt(getSettings("buttonSize")); - const offset = 10; + const offset = parseInt(getSettings("buttonOffset")); switch (getSettings("buttonDirection")) { case "top": return { top: -buttonSize - offset, left: -buttonSize / 2 }; diff --git a/src/content/components/TranslatePanel.js b/src/content/components/TranslatePanel.js index 5c2884a..9da01eb 100644 --- a/src/content/components/TranslatePanel.js +++ b/src/content/components/TranslatePanel.js @@ -31,7 +31,7 @@ export default class TranslatePanel extends Component { const windowWidth = document.documentElement.clientWidth; const windowHeight = document.documentElement.clientHeight; const referencePosition = this.props.position; - const offset = 10; + const offset = parseInt(getSettings("panelOffset")); let position = { x: 0, y: 0 }; const panelDirection = getSettings("panelDirection"); diff --git a/src/settings/defaultSettings.js b/src/settings/defaultSettings.js index 5c6f144..8c8bf82 100644 --- a/src/settings/defaultSettings.js +++ b/src/settings/defaultSettings.js @@ -143,7 +143,7 @@ export default [ }, { id: "buttonDirection", - title: "buttonPositionLabel", + title: "displayDirectionLabel", captions: [], type: "select", default: "bottomRight", @@ -182,6 +182,15 @@ export default [ } ], new: true + }, + { + id: "buttonOffset", + title: "positionOffsetLabel", + captions: [], + type: "number", + default: 10, + placeholder: 10, + new: true } ] }, @@ -281,6 +290,15 @@ export default [ ], new: true }, + { + id: "panelOffset", + title: "positionOffsetLabel", + captions: [], + type: "number", + default: 10, + placeholder: 10, + new: true + }, { id: "resultFontColor", title: "resultFontColorLabel",