Merge pull request #60 from divinerapier/master

fix: time.After will cause memory leaks
This commit is contained in:
Aleksandr Zelenin 2021-09-13 17:15:36 +03:00 committed by GitHub
commit e162b22637
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1,6 +1,7 @@
package client
import (
"context"
"errors"
"sync"
"time"
@ -123,17 +124,20 @@ func (client *Client) Send(req Request) (*Response, error) {
client.catchersStore.Store(req.Extra, catcher)
defer func() {
close(catcher)
client.catchersStore.Delete(req.Extra)
close(catcher)
}()
client.jsonClient.Send(req)
ctx, cancel := context.WithTimeout(context.Background(), client.catchTimeout)
defer cancel()
select {
case response := <-catcher:
return response, nil
case <-time.After(client.catchTimeout):
case <-ctx.Done():
return nil, errors.New("response catching timeout")
}
}