narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests Actions Packages Projects Releases 4 Wiki Activity
conversations-classic/src/main/java/eu/siacs/conversations/ui
History
Daniel Gultsch 7177c523a1 Do not insert text shared over XMPP uri when already drafting message 
XMPP uris in the style of `xmpp:test@domain.tld?body=Something` can be used to
directly share a message with a specific contact. Previously the text was
always appended to the message currently in draft. The message was never send
automatically. Essentially those links where treated like normal text share
intents (for example when sharing a URL from the browser) but without the
contact selection.

There is a concern (CVE-2018-18467) that when this URI is invoked automatically
and the user is currently drafting a long message to that particular contact
the text could be inserted in the draft field (input box) without the user
noticing.

To circumvent that the text shared over XMPP uris that contain a particular
contact is now appended only if the draft box is currently empty.

Sharing text normally (**with** manual contact selection) is still treated the
same; meaning the shared text will be appended to the current draft. This is
intended behaviour to make the
'Hey I have this cool link here;' *open browser*, *share link* - secenario
work.
2018-10-19 15:39:31 +02:00
..
adapter show cancelled instead of delivery failed if user requested to abort transfer 2018-10-07 14:59:08 +02:00
forms fixed media preview for file types other than images 2018-09-12 14:37:41 +02:00
interfaces show conversation media in contact/conference details 2018-09-15 19:38:45 +02:00
service check if wake lock needs reinit when pressing start/pause in audio player 2018-09-23 11:47:13 +02:00
text catch conversations.im invite urls directly in fragment 2018-09-18 17:15:52 +02:00
util make jids appear as monospace in dialogs 2018-10-06 17:03:12 +02:00
widget show conversation media in contact/conference details 2018-09-15 19:38:45 +02:00
AboutActivity.java made font size selectable 2018-04-01 21:37:21 +02:00
AboutPreference.java dynamically reference app name in version string 2018-04-26 21:21:17 +02:00
AbstractSearchableListItemActivity.java replace deprecated action bar with toolbar (#2872) 2018-03-18 09:30:22 +01:00
ActionBarActivity.java Merge Open Street Map plugin 2018-04-16 17:39:43 -05:00
BlockContactDialog.java make jids appear as monospace in dialogs 2018-10-06 17:03:12 +02:00
BlocklistActivity.java dynamically get known hosts in dialog 2018-03-14 10:07:52 +01:00
ChangePasswordActivity.java replace deprecated action bar with toolbar (#2872) 2018-03-18 09:30:22 +01:00
ChooseContactActivity.java click on item selection 2018-06-27 17:17:31 +02:00
ConferenceDetailsActivity.java do not show media overview in contact/conference details when missing storage permission 2018-09-17 21:24:25 +02:00
ContactDetailsActivity.java make jids appear as monospace in dialogs 2018-10-06 17:03:12 +02:00
ConversationActivity.java added splash screen 2018-03-07 22:30:36 +01:00
ConversationFragment.java Do not insert text shared over XMPP uri when already drafting message 2018-10-19 15:39:31 +02:00
ConversationsActivity.java Do not insert text shared over XMPP uri when already drafting message 2018-10-19 15:39:31 +02:00
ConversationsOverviewFragment.java fixed media preview for file types other than images 2018-09-12 14:37:41 +02:00
CreateConferenceDialog.java refined create conference dialog 2018-06-24 11:23:10 +02:00
EditAccountActivity.java do not show 'open website' button after info has changed 2018-10-11 05:06:46 +02:00
EnterJidDialog.java dynamically get known hosts in dialog 2018-03-14 10:07:52 +01:00
JoinConferenceDialog.java made checkboxes and radiobuttons stylable 2018-04-01 09:18:12 +02:00
LocationActivity.java use Tor to download map tiles if configured to do so 2018-05-11 12:42:39 +02:00
MagicCreateActivity.java replace deprecated action bar with toolbar (#2872) 2018-03-18 09:30:22 +01:00
ManageAccountActivity.java prevent double tapping on overflow menu 2018-03-19 09:43:33 +01:00
MediaBrowserActivity.java introduce media browser activity 2018-09-15 21:10:17 +02:00
MemorizingActivity.java made font size selectable 2018-04-01 21:37:21 +02:00
OmemoActivity.java use text styles in more places 2018-03-07 22:30:35 +01:00
PublishGroupChatProfilePictureActivity.java show toast before finishing publish activity 2018-06-18 17:32:48 +02:00
PublishProfilePictureActivity.java change avatar size in details screens depedning on screen width 2018-06-23 19:00:23 +02:00
RecordingActivity.java make recording activity not crash if microphone was in use. fixes #3160 2018-08-31 11:04:18 +02:00
ScanActivity.java fixe scan in OmemoActivities 2018-03-07 22:30:35 +01:00
SearchActivity.java fixed media preview for file types other than images 2018-09-12 14:37:41 +02:00
SettingsActivity.java fixed media preview for file types other than images 2018-09-12 14:37:41 +02:00
SettingsFragment.java initial work toward api 26+ 2018-09-05 21:37:12 +02:00
ShareLocationActivity.java added search result context menu + date separators 2018-04-28 16:32:23 +02:00
ShareViaAccountActivity.java removed unused paramater 'newTask' from switchToConversation api 2018-10-19 15:18:36 +02:00
ShareWithActivity.java fixed text sharing in direct sharing 2018-09-18 17:03:08 +02:00
ShortcutActivity.java support contact shortcuts (#2918) 2018-04-04 09:33:07 +02:00
ShowLocationActivity.java fixups for Share location merger 2018-04-21 18:25:46 +02:00
StartConversationActivity.java Do not insert text shared over XMPP uri when already drafting message 2018-10-19 15:39:31 +02:00
TimePreference.java Update summary in TimePreference change listener 2014-12-15 17:46:32 -05:00
TrustKeysActivity.java open trust key screen when download is in progress 2018-07-07 08:53:11 +02:00
UiCallback.java code clean up 2015-10-12 12:36:54 +02:00
UiInformableCallback.java transcode videos before sharing. change storage location 2017-01-24 20:17:36 +01:00
UriHandlerActivity.java Extend QR scanner to support VCard with IMPP field (#3027) 2018-05-16 15:08:38 +02:00
WelcomeActivity.java replace deprecated action bar with toolbar (#2872) 2018-03-18 09:30:22 +01:00
XmppActivity.java Do not insert text shared over XMPP uri when already drafting message 2018-10-19 15:39:31 +02:00
XmppFragment.java create interface for onBackendConnected 2018-03-13 22:44:08 +01:00