From dfc1cea882b33c7bf27bca5a349377b6ed966a75 Mon Sep 17 00:00:00 2001 From: Sam Whited Date: Sat, 17 Jan 2015 09:10:33 -0500 Subject: [PATCH] Correct the download file string on notifications Fixes #896 --- .../services/NotificationService.java | 7 ++---- .../siacs/conversations/utils/UIHelper.java | 22 ++++++++++--------- src/main/res/values-de/strings.xml | 1 - src/main/res/values-es/strings.xml | 1 - src/main/res/values-eu/strings.xml | 1 - src/main/res/values-fr/strings.xml | 1 - src/main/res/values-nl/strings.xml | 1 - src/main/res/values/strings.xml | 8 +++---- 8 files changed, 18 insertions(+), 24 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/services/NotificationService.java b/src/main/java/eu/siacs/conversations/services/NotificationService.java index efdd2b608..8c3aff16c 100644 --- a/src/main/java/eu/siacs/conversations/services/NotificationService.java +++ b/src/main/java/eu/siacs/conversations/services/NotificationService.java @@ -264,11 +264,8 @@ public class NotificationService { if ((message = getFirstDownloadableMessage(messages)) != null) { mBuilder.addAction( R.drawable.ic_action_download, - mXmppConnectionService.getResources().getString( - message.getType() == Message.TYPE_IMAGE ? - R.string.download_image : - R.string.download_file - ), + mXmppConnectionService.getResources().getString(R.string.download_x_file, + UIHelper.getFileDescriptionString(mXmppConnectionService, message)), createDownloadIntent(message) ); } diff --git a/src/main/java/eu/siacs/conversations/utils/UIHelper.java b/src/main/java/eu/siacs/conversations/utils/UIHelper.java index b00447a47..f468d9ae0 100644 --- a/src/main/java/eu/siacs/conversations/utils/UIHelper.java +++ b/src/main/java/eu/siacs/conversations/utils/UIHelper.java @@ -18,9 +18,9 @@ import android.util.Pair; public class UIHelper { private static final int SHORT_DATE_FLAGS = DateUtils.FORMAT_SHOW_DATE - | DateUtils.FORMAT_NO_YEAR | DateUtils.FORMAT_ABBREV_ALL; + | DateUtils.FORMAT_NO_YEAR | DateUtils.FORMAT_ABBREV_ALL; private static final int FULL_DATE_FLAGS = DateUtils.FORMAT_SHOW_TIME - | DateUtils.FORMAT_ABBREV_ALL | DateUtils.FORMAT_SHOW_DATE; + | DateUtils.FORMAT_ABBREV_ALL | DateUtils.FORMAT_SHOW_DATE; public static String readableTimeDifference(Context context, long time) { return readableTimeDifference(context, time, false); @@ -72,8 +72,8 @@ public class UIHelper { cal1.setTime(a); cal2.setTime(b); return cal1.get(Calendar.YEAR) == cal2.get(Calendar.YEAR) - && cal1.get(Calendar.DAY_OF_YEAR) == cal2 - .get(Calendar.DAY_OF_YEAR); + && cal1.get(Calendar.DAY_OF_YEAR) == cal2 + .get(Calendar.DAY_OF_YEAR); } public static String lastseen(Context context, long time) { @@ -106,8 +106,8 @@ public class UIHelper { return 0xFF202020; } int colors[] = {0xFFe91e63, 0xFF9c27b0, 0xFF673ab7, 0xFF3f51b5, - 0xFF5677fc, 0xFF03a9f4, 0xFF00bcd4, 0xFF009688, 0xFFff5722, - 0xFF795548, 0xFF607d8b}; + 0xFF5677fc, 0xFF03a9f4, 0xFF00bcd4, 0xFF009688, 0xFFff5722, + 0xFF795548, 0xFF607d8b}; return colors[(int) ((name.hashCode() & 0xffffffffl) % colors.length)]; } @@ -120,8 +120,8 @@ public class UIHelper { case Downloadable.STATUS_DOWNLOADING: if (message.getType() == Message.TYPE_FILE) { return new Pair<>(context.getString(R.string.receiving_x_file, - getFileDescriptionString(context,message), - d.getProgress()),true); + getFileDescriptionString(context,message), + d.getProgress()),true); } else { return new Pair<>(context.getString(R.string.receiving_image, d.getProgress()),true); } @@ -129,7 +129,7 @@ public class UIHelper { case Downloadable.STATUS_OFFER_CHECK_FILESIZE: if (message.getType() == Message.TYPE_FILE) { return new Pair<>(context.getString(R.string.x_file_offered_for_download, - getFileDescriptionString(context,message)),true); + getFileDescriptionString(context,message)),true); } else { return new Pair<>(context.getString(R.string.image_offered_for_download),true); } @@ -153,7 +153,7 @@ public class UIHelper { } else if (message.getType() == Message.TYPE_FILE) { if (message.getStatus() == Message.STATUS_RECEIVED) { return new Pair<>(context.getString(R.string.received_x_file, - getFileDescriptionString(context, message)), true); + getFileDescriptionString(context, message)), true); } else { return new Pair<>(getFileDescriptionString(context,message),true); } @@ -183,6 +183,8 @@ public class UIHelper { return context.getString(R.string.audio); } else if(mime.startsWith("video/")) { return context.getString(R.string.video); + } else if (mime.startsWith("image/")) { + return context.getString(R.string.image); } else if (mime.contains("pdf")) { return context.getString(R.string.pdf_document) ; } else { diff --git a/src/main/res/values-de/strings.xml b/src/main/res/values-de/strings.xml index 1240da79c..b81f440dd 100644 --- a/src/main/res/values-de/strings.xml +++ b/src/main/res/values-de/strings.xml @@ -337,7 +337,6 @@ Verhindert, dass Android die Verbindung unterbricht Datei auswählen Empfange %1$s Datei (%2$d%% heruntergeladen) - Download %s Datei Öffne %s Datei Sende (%1$d%% gesendet) Bereite Datei für die Übertragung vor diff --git a/src/main/res/values-es/strings.xml b/src/main/res/values-es/strings.xml index fba7dbc8f..f792b3f73 100644 --- a/src/main/res/values-es/strings.xml +++ b/src/main/res/values-es/strings.xml @@ -338,7 +338,6 @@ Mantener el servicio en primer plano previene que el sistema cierre la conexión Seleccionar archivo Recibiendo archivo %1$s (%2$d%% completado) - Descargar archivo %s Abrir archivo %s Enviando (%1$d%% completado) Preparando transferencia de archivo diff --git a/src/main/res/values-eu/strings.xml b/src/main/res/values-eu/strings.xml index 04388f4f6..a1218bb2d 100644 --- a/src/main/res/values-eu/strings.xml +++ b/src/main/res/values-eu/strings.xml @@ -311,7 +311,6 @@ Sistema eragileak zure konexioa hiltzea galarazten du Fitxategia aukeratu %1$s fitxategia jasotzen (%2$d%% osatua) - %s fitxategia deskargatu %s fitxategia ireki bidaltzen (%1$d%% osatua) Fitxategia transmisiorako prestatzen diff --git a/src/main/res/values-fr/strings.xml b/src/main/res/values-fr/strings.xml index daae60769..7876ef3e5 100644 --- a/src/main/res/values-fr/strings.xml +++ b/src/main/res/values-fr/strings.xml @@ -306,7 +306,6 @@ Evite que le système ferme votre connexion Choix d\'un fichier Réception %1$s fichier (%2$d%% complété) -Télecharger %s fichier Ouvrir %s fichier envoi (%1$d%% complété) Préparation du fichier pour l\'envoi diff --git a/src/main/res/values-nl/strings.xml b/src/main/res/values-nl/strings.xml index 91484794e..965af37a6 100644 --- a/src/main/res/values-nl/strings.xml +++ b/src/main/res/values-nl/strings.xml @@ -338,7 +338,6 @@ Belet het besturingssysteem van je verbinding te onderbreken Kies bestand Ontvange van %1$s bestand (%2$d%% voltooid) - Download %s bestand Open %s bestand versturen (%1$d%% voltooid) Bestand klaarmaken voor versturen diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml index e6776a606..fb6878ce9 100644 --- a/src/main/res/values/strings.xml +++ b/src/main/res/values/strings.xml @@ -85,7 +85,6 @@ Send OpenPGP encrypted message Your nickname has been changed Download Image - Download File Image file offered for download Send unencrypted Decryption failed. Maybe you don’t have the proper private key. @@ -439,9 +438,10 @@ Change the emoticons key to an enter key audio file video file + image file PDF document Received %s - Disable foreground service - Touch to open Conversations - Avatar has been published! + Disable foreground service + Touch to open Conversations + Avatar has been published!