narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests Actions Packages Projects Releases 4 Wiki Activity

submit empty page when changing filter

Browse source
This commit is contained in:
Daniel Gultsch 2023-03-08 09:52:57 +01:00
parent eb15dc1260
commit c1ef2ac628
No known key found for this signature in database
GPG key ID: F43D18AD2A0982C2
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/src/main/java/im/conversations/android/ui/fragment/main/OverviewFragment.java
View file

@ -14,6 +14,7 @@ import androidx.databinding.DataBindingUtil;
import androidx.drawerlayout.widget.DrawerLayout; import androidx.drawerlayout.widget.DrawerLayout;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
import androidx.paging.PagingData;
import com.google.android.material.elevation.SurfaceColors; import com.google.android.material.elevation.SurfaceColors;
import com.google.android.material.search.SearchView; import com.google.android.material.search.SearchView;
import im.conversations.android.IDs; import im.conversations.android.IDs;
@ -47,6 +48,7 @@ public class OverviewFragment extends Fragment {
}; };
private OverviewViewModel overviewViewModel; private OverviewViewModel overviewViewModel;
private ChatOverviewAdapter chatOverviewAdapter;
@Override @Override
public View onCreateView( public View onCreateView(
@ -84,7 +86,7 @@ public class OverviewFragment extends Fragment {
.getChatFilterAvailable() .getChatFilterAvailable()
.observe(getViewLifecycleOwner(), this::onChatFilterAvailable); .observe(getViewLifecycleOwner(), this::onChatFilterAvailable);
this.configureDrawerLayoutToCloseOnBackPress(); this.configureDrawerLayoutToCloseOnBackPress();
final var chatOverviewAdapter = new ChatOverviewAdapter(new ChatOverviewComparator()); this.chatOverviewAdapter = new ChatOverviewAdapter(new ChatOverviewComparator());
binding.chats.setAdapter(chatOverviewAdapter); binding.chats.setAdapter(chatOverviewAdapter);
this.overviewViewModel this.overviewViewModel
.getChats() .getChats()
@ -150,6 +152,11 @@ public class OverviewFragment extends Fragment {
} }
private void setChatFilter(final ChatFilter chatFilter) { private void setChatFilter(final ChatFilter chatFilter) {
// this prevents animation between ChatFilter changes
// TODO This was added primarily to fix the lack of 'scrolling to top' after filter changes
// (if an item was in both); if we find a better solution we might as well bring back
// animation
chatOverviewAdapter.submitData(getLifecycle(), PagingData.empty());
overviewViewModel.setChatFilter(chatFilter); overviewViewModel.setChatFilter(chatFilter);
binding.drawerLayout.close(); binding.drawerLayout.close();
} }