narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests Actions Packages Projects Releases 4 Wiki Activity

use lower margins on between in-call buttons on small displays

Browse source 
hopefully fixes #3890
This commit is contained in:
Daniel Gultsch 2020-11-13 16:11:38 +01:00
parent 386b224123
commit 952387cb5a
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/main/res/layout/activity_rtp_session.xml
View file

@ -174,7 +174,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_margin="12dp" android:layout_margin="@dimen/in_call_fab_margin"
android:layout_toStartOf="@+id/end_call" android:layout_toStartOf="@+id/end_call"
android:layout_toLeftOf="@+id/end_call" android:layout_toLeftOf="@+id/end_call"
android:visibility="gone" android:visibility="gone"
@ -188,7 +188,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_centerInParent="true" android:layout_centerInParent="true"
android:layout_margin="16dp" android:layout_margin="@dimen/in_call_fab_margin_center"
android:src="@drawable/ic_call_end_white_48dp" android:src="@drawable/ic_call_end_white_48dp"
android:visibility="visible" android:visibility="visible"
app:backgroundTint="@color/red700" app:backgroundTint="@color/red700"
@ -201,7 +201,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_margin="12dp" android:layout_margin="@dimen/in_call_fab_margin"
android:layout_toEndOf="@+id/end_call" android:layout_toEndOf="@+id/end_call"
android:layout_toRightOf="@+id/end_call" android:layout_toRightOf="@+id/end_call"
android:visibility="gone" android:visibility="gone"
@ -215,7 +215,7 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:layout_margin="12dp" android:layout_margin="@dimen/in_call_fab_margin"
android:layout_toEndOf="@+id/in_call_action_right" android:layout_toEndOf="@+id/in_call_action_right"
android:layout_toRightOf="@+id/in_call_action_right" android:layout_toRightOf="@+id/in_call_action_right"
android:visibility="gone" android:visibility="gone"

4
src/main/res/values-w384dp/dimens.xml
View file

@ -1,6 +1,10 @@
<resources> <resources>
<!-- 384dp is the screen width of the Nexus 4. Something like a Moto G is smaller but a Nexus 5X is larger --> <!-- 384dp is the screen width of the Nexus 4. Something like a Moto G is smaller but a Nexus 5X is larger -->
<!-- https://material.io/devices/ --> <!-- https://material.io/devices/ -->
<dimen name="in_call_fab_margin">12dp</dimen>
<dimen name="in_call_fab_margin_center">16dp</dimen>
<dimen name="fineprint_size">12sp</dimen> <dimen name="fineprint_size">12sp</dimen>
<dimen name="audio_player_width">288dp</dimen> <dimen name="audio_player_width">288dp</dimen>
<dimen name="image_preview_width">288dp</dimen> <dimen name="image_preview_width">288dp</dimen>

2
src/main/res/values/dimens.xml
View file

@ -1,5 +1,7 @@
<resources> <resources>
<!-- Default screen margins, per the Android Design guidelines. --> <!-- Default screen margins, per the Android Design guidelines. -->
<dimen name="in_call_fab_margin">8dp</dimen>
<dimen name="in_call_fab_margin_center">12dp</dimen>
<dimen name="activity_horizontal_margin">8dp</dimen> <dimen name="activity_horizontal_margin">8dp</dimen>
<dimen name="activity_vertical_margin">8dp</dimen> <dimen name="activity_vertical_margin">8dp</dimen>
<dimen name="card_padding_regular">16dp</dimen> <dimen name="card_padding_regular">16dp</dimen>