From 7fb617e39a97c62cf8df2e16f3bc10546ce0c742 Mon Sep 17 00:00:00 2001 From: Daniel Gultsch Date: Wed, 2 Sep 2020 10:14:00 +0200 Subject: [PATCH] disable 'leave before join' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit leaving a MUC before joining it was a work around for servers that did not treat a join as a full join and didn’t send the full user list if they thought the user was still in the room. this happens if Conversations restarts after an inproper disconnect. The MUC will think the user is still in the room. however nowadays most modern servers will treat joins as full joins. on the user hand leave before join would trigger flood prevention on ejabberds and race the first message with the actual join (making the message arrive before the user is considered in the room) --- src/main/java/eu/siacs/conversations/Config.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/eu/siacs/conversations/Config.java b/src/main/java/eu/siacs/conversations/Config.java index 86d771740..074432030 100644 --- a/src/main/java/eu/siacs/conversations/Config.java +++ b/src/main/java/eu/siacs/conversations/Config.java @@ -119,7 +119,7 @@ public final class Config { public static final boolean ONLY_INTERNAL_STORAGE = false; //use internal storage instead of sdcard to save attachments public static final boolean IGNORE_ID_REWRITE_IN_MUC = true; - public static final boolean MUC_LEAVE_BEFORE_JOIN = true; + public static final boolean MUC_LEAVE_BEFORE_JOIN = false; public static final boolean USE_LMC_VERSION_1_1 = true;