narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests 2 Actions Packages Projects Releases 4 Wiki Activity

null PeerConnection reference before disposing; otherwise getState() might be issued against disposed object

Browse source
This commit is contained in:
Daniel Gultsch 2022-12-01 20:46:18 +01:00
parent 80d195d35e
commit 2c7c44e957
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/main/java/eu/siacs/conversations/xmpp/jingle/WebRTCWrapper.java
View file

@ -445,8 +445,8 @@ public class WebRTCWrapper {
final AppRTCAudioManager audioManager = this.appRTCAudioManager; final AppRTCAudioManager audioManager = this.appRTCAudioManager;
final EglBase eglBase = this.eglBase; final EglBase eglBase = this.eglBase;
if (peerConnection != null) { if (peerConnection != null) {
dispose(peerConnection);
this.peerConnection = null; this.peerConnection = null;
dispose(peerConnection);
} }
if (audioManager != null) { if (audioManager != null) {
toneManager.setAppRtcAudioManagerHasControl(false); toneManager.setAppRtcAudioManagerHasControl(false);
@ -467,6 +467,7 @@ public class WebRTCWrapper {
this.eglBase = null; this.eglBase = null;
} }
if (peerConnectionFactory != null) { if (peerConnectionFactory != null) {
this.peerConnectionFactory = null;
peerConnectionFactory.dispose(); peerConnectionFactory.dispose();
} }
} }