narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests 2 Actions Packages Projects Releases 4 Wiki Activity

add 'id' attribute to outgoing ICE-UDP candidates

Browse source 
this attribute is mandatory as per the XEP.
This commit is contained in:
Emmanuel Gil Peyrot 2020-12-26 20:32:04 +01:00 committed by Daniel Gultsch
parent 69dca53bf3
commit 17c697eed9
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/main/java/eu/siacs/conversations/xmpp/jingle/stanzas/IceUdpTransportInfo.java
View file

@ -14,6 +14,7 @@ import java.util.LinkedHashMap;
import java.util.List; import java.util.List;
import java.util.Locale; import java.util.Locale;
import java.util.Map; import java.util.Map;
import java.util.UUID;
import eu.siacs.conversations.xml.Element; import eu.siacs.conversations.xml.Element;
import eu.siacs.conversations.xml.Namespace; import eu.siacs.conversations.xml.Namespace;
@ -93,6 +94,7 @@ public class IceUdpTransportInfo extends GenericTransportInfo {
if (pair.length == 2 && "candidate".equals(pair[0])) { if (pair.length == 2 && "candidate".equals(pair[0])) {
final String[] segments = pair[1].split(" "); final String[] segments = pair[1].split(" ");
if (segments.length >= 6) { if (segments.length >= 6) {
final String id = UUID.randomUUID().toString();
final String foundation = segments[0]; final String foundation = segments[0];
final String component = segments[1]; final String component = segments[1];
final String transport = segments[2].toLowerCase(Locale.ROOT); final String transport = segments[2].toLowerCase(Locale.ROOT);
@ -109,6 +111,7 @@ public class IceUdpTransportInfo extends GenericTransportInfo {
candidate.setAttribute("generation", additional.get("generation")); candidate.setAttribute("generation", additional.get("generation"));
candidate.setAttribute("rel-addr", additional.get("raddr")); candidate.setAttribute("rel-addr", additional.get("raddr"));
candidate.setAttribute("rel-port", additional.get("rport")); candidate.setAttribute("rel-port", additional.get("rport"));
candidate.setAttribute("id", id);
candidate.setAttribute("ip", connectionAddress); candidate.setAttribute("ip", connectionAddress);
candidate.setAttribute("port", port); candidate.setAttribute("port", port);
candidate.setAttribute("priority", priority); candidate.setAttribute("priority", priority);