From d98486d1cab6083688b68c21d663ab3f9ad572bc Mon Sep 17 00:00:00 2001
From: iNPUTmice <daniel@gultsch.de>
Date: Sat, 29 Nov 2014 19:09:28 +0100
Subject: [PATCH] fixed npe for broken bookmarks

---
 .../services/XmppConnectionService.java           | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java
index 12237f731..128f61a12 100644
--- a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java
+++ b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java
@@ -813,13 +813,11 @@ public class XmppConnectionService extends Service {
 							Conversation conversation = find(bookmark);
 							if (conversation != null) {
 								conversation.setBookmark(bookmark);
-							} else {
-								if (bookmark.autojoin()) {
-									conversation = findOrCreateConversation(
-											account, bookmark.getJid(), true);
-									conversation.setBookmark(bookmark);
-									joinMuc(conversation);
-								}
+							} else if (bookmark.autojoin() && bookmark.getJid() != null) {
+								conversation = findOrCreateConversation(
+										account, bookmark.getJid(), true);
+								conversation.setBookmark(bookmark);
+								joinMuc(conversation);
 							}
 						}
 					}
@@ -980,6 +978,9 @@ public class XmppConnectionService extends Service {
 	public Conversation find(final List<Conversation> haystack,
 			final Account account,
 			final Jid jid) {
+		if (jid == null ) {
+			return null;
+		}
 		for (Conversation conversation : haystack) {
 			if ((account == null || conversation.getAccount() == account)
 					&& (conversation.getContactJid().toBareJid().equals(jid.toBareJid()))) {