narayana/anotherim
narayana/anotherim
3
2
Fork 0
Code Issues 3 Pull requests 2 Actions Packages Projects Releases 4 Wiki Activity

fix array out of bounds. fixes #4334

Browse source
This commit is contained in:
Daniel Gultsch 2022-07-01 15:54:21 +02:00
parent 73c7d76bd6
commit d8fd59394c
1 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/main/java/eu/siacs/conversations/ui/util/EditMessageActionModeCallback.java
View file

@ -48,17 +48,28 @@ public class EditMessageActionModeCallback implements ActionMode.Callback {
public EditMessageActionModeCallback(EditMessage editMessage) { public EditMessageActionModeCallback(EditMessage editMessage) {
this.editMessage = editMessage; this.editMessage = editMessage;
this.clipboardManager = (ClipboardManager) editMessage.getContext().getSystemService(Context.CLIPBOARD_SERVICE); this.clipboardManager =
(ClipboardManager)
editMessage.getContext().getSystemService(Context.CLIPBOARD_SERVICE);
} }
@Override @Override
public boolean onCreateActionMode(ActionMode mode, Menu menu) { public boolean onCreateActionMode(final ActionMode mode, final Menu menu) {
final MenuInflater inflater = mode.getMenuInflater(); final MenuInflater inflater = mode.getMenuInflater();
inflater.inflate(R.menu.edit_message_actions, menu); inflater.inflate(R.menu.edit_message_actions, menu);
final MenuItem pasteAsQuote = menu.findItem(R.id.paste_as_quote); final MenuItem pasteAsQuote = menu.findItem(R.id.paste_as_quote);
final ClipData primaryClip = clipboardManager.getPrimaryClip(); final ClipData primaryClip = clipboardManager.getPrimaryClip();
if (primaryClip != null && primaryClip.getItemCount() >= 0) { if (primaryClip != null && primaryClip.getItemCount() > 0) {
pasteAsQuote.setVisible(primaryClip.getDescription().getMimeType(0).startsWith("text/") && !TextUtils.isEmpty(primaryClip.getItemAt(0).getText())); final String mimeType;
try {
mimeType = primaryClip.getDescription().getMimeType(0);
} catch (final Exception e) {
pasteAsQuote.setVisible(false);
return true;
}
pasteAsQuote.setVisible(
mimeType.startsWith("text/")
&& !TextUtils.isEmpty(primaryClip.getItemAt(0).getText()));
} else { } else {
pasteAsQuote.setVisible(false); pasteAsQuote.setVisible(false);
} }
@ -71,10 +82,10 @@ public class EditMessageActionModeCallback implements ActionMode.Callback {
} }
@Override @Override
public boolean onActionItemClicked(ActionMode mode, MenuItem item) { public boolean onActionItemClicked(final ActionMode mode, final MenuItem item) {
if (item.getItemId() == R.id.paste_as_quote) { if (item.getItemId() == R.id.paste_as_quote) {
final ClipData primaryClip = clipboardManager.getPrimaryClip(); final ClipData primaryClip = clipboardManager.getPrimaryClip();
if (primaryClip != null && primaryClip.getItemCount() >= 1) { if (primaryClip != null && primaryClip.getItemCount() > 0) {
editMessage.insertAsQuote(primaryClip.getItemAt(0).getText().toString()); editMessage.insertAsQuote(primaryClip.getItemAt(0).getText().toString());
return true; return true;
} }
@ -83,7 +94,5 @@ public class EditMessageActionModeCallback implements ActionMode.Callback {
} }
@Override @Override
public void onDestroyActionMode(ActionMode mode) { public void onDestroyActionMode(ActionMode mode) {}
}
} }