From 786d9895c87db642ca5c7a2522a905b4953ee8c4 Mon Sep 17 00:00:00 2001
From: Daniel Gultsch <daniel@gultsch.de>
Date: Mon, 26 Mar 2018 05:43:22 +0200
Subject: [PATCH] fixed popup menu in dark theme

---
 src/main/res/layout/toolbar.xml | 4 ++--
 src/main/res/values/attrs.xml   | 2 ++
 src/main/res/values/themes.xml  | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/res/layout/toolbar.xml b/src/main/res/layout/toolbar.xml
index 4bb507caf..f6e306ff1 100644
--- a/src/main/res/layout/toolbar.xml
+++ b/src/main/res/layout/toolbar.xml
@@ -4,8 +4,8 @@
     android:layout_height="wrap_content"
     android:background="?attr/colorPrimary"
     android:minHeight="?attr/actionBarSize"
-    android:elevation="6dp"
+    android:elevation="4dp"
     android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar"
-    app:popupTheme="@style/ThemeOverlay.AppCompat.Light"
+    app:popupTheme="?popupOverlayStyle"
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto" />
diff --git a/src/main/res/values/attrs.xml b/src/main/res/values/attrs.xml
index 4fbdd12cb..45c3ea176 100644
--- a/src/main/res/values/attrs.xml
+++ b/src/main/res/values/attrs.xml
@@ -71,4 +71,6 @@
         <attr name="backgroundColor" format="reference|color"/>
     </declare-styleable>
 
+    <attr name="popupOverlayStyle" format="reference"/>
+
 </resources>
\ No newline at end of file
diff --git a/src/main/res/values/themes.xml b/src/main/res/values/themes.xml
index d6d3f2b33..79404e4ce 100644
--- a/src/main/res/values/themes.xml
+++ b/src/main/res/values/themes.xml
@@ -5,6 +5,7 @@
         <item name="colorPrimary">@color/primary500</item>
         <item name="colorPrimaryDark">@color/primary700</item>
         <item name="colorAccent">@color/accent</item>
+        <item name="popupOverlayStyle">@style/ThemeOverlay.AppCompat.Light</item>
 
         <item name="color_background_primary">@color/grey50</item>
         <item name="color_background_secondary">@color/grey200</item>
@@ -81,7 +82,7 @@
         <item name="colorPrimary">@color/primary800</item>
         <item name="colorPrimaryDark">@color/primary900</item>
         <item name="colorAccent">@color/accent</item>
-
+        <item name="popupOverlayStyle">@style/ThemeOverlay.AppCompat.Dark</item>
 
         <item name="color_background_primary">@color/grey800</item>
         <item name="color_background_secondary">@color/grey900</item>