From 705cc33347a57280679f16616da1c56d253b6e7c Mon Sep 17 00:00:00 2001 From: kosyak Date: Tue, 21 May 2024 21:09:59 +0200 Subject: [PATCH] Revert "fix reply text handling" This reverts commit 8c1d825bf30d641247064063cfcc75a59bc5ab41. --- .../siacs/conversations/entities/Message.java | 33 ++++++++----------- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/entities/Message.java b/src/main/java/eu/siacs/conversations/entities/Message.java index 90eee7026..abf2bda06 100644 --- a/src/main/java/eu/siacs/conversations/entities/Message.java +++ b/src/main/java/eu/siacs/conversations/entities/Message.java @@ -841,7 +841,7 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable public SpannableStringBuilder getBodyForDisplaying() { if (replyMessage != null) { try { - return new SpannableStringBuilder(MessageUtils.filterLtrRtl(getReplyText(replyMessage) + "\n" + removeReplyFallback(this, replyMessage)).trim()); + return new SpannableStringBuilder(MessageUtils.filterLtrRtl(getReplyText(replyMessage) + "\n" + removeReplyFallback(this)).trim()); } catch (IndexOutOfBoundsException e) { return new SpannableStringBuilder(MessageUtils.filterLtrRtl(this.body).trim()); } @@ -859,7 +859,7 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable } private StringBuilder getReplyText(Message message) { - StringBuilder reply = removeReplyFallback(message, message.replyMessage); + StringBuilder reply = removeReplyFallback(message); reply.insert(0, '>'); for (int i=0;i replyFallback = message.getFallbacks("urn:xmpp:reply:0"); - if (replyFallback.isEmpty()) { - return sb; - } - - Element bodyFallback = replyFallback.get(0).findChild("body"); - int startCodePoint = Integer.parseInt(bodyFallback.getAttribute("start")); - int endCodePoint = Integer.parseInt(bodyFallback.getAttribute("end")); - - if (startCodePoint < 0) return sb; - if (endCodePoint > sb.length()) return sb; - - sb.replace(message.body.offsetByCodePoints(0, startCodePoint), message.body.offsetByCodePoints(0, endCodePoint), ""); + List replyFallback = message.getFallbacks("urn:xmpp:reply:0"); + if (replyFallback.size() == 0) { + return sb; } + Element bodyFallback = replyFallback.get(0).findChild("body"); + int startCodePoint = Integer.parseInt(bodyFallback.getAttribute("start")); + int endCodePoint = Integer.parseInt(bodyFallback.getAttribute("end")); + + if (startCodePoint < 0) return sb; + if (endCodePoint > sb.length()) return sb; + + sb.replace(message.body.offsetByCodePoints(0, startCodePoint), message.body.offsetByCodePoints(0, endCodePoint), ""); return sb; }