anotherim/anotherim-desktop
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Handle broken VAPI in older vala

Browse source
This commit is contained in:
Marvin W 2021-04-11 15:57:53 +02:00
parent 4edab3c8d6
commit fe160d94ba
No known key found for this signature in database
GPG key ID: 072E9235DB996F2A
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
plugins/rtp/src/stream.vala
View file

@ -300,7 +300,17 @@ public class Dino.Plugins.Rtp.Stream : Xmpp.Xep.JingleRtp.Stream {
}
}
if (push_recv_data) {
recv_rtp.push_buffer(new Gst.Buffer.wrapped((owned) data));
Gst.Buffer buffer = new Gst.Buffer.wrapped((owned) data);
// FIXME: VAPI file in Vala < 0.49.1 has a bug that results in broken ownership of buffer in push_buffer()
// We workaround by using the plain signal. The signal unfortunately will cause an unnecessary copy of
// the underlying buffer, so and some point we should move over to the new version (once we require
// Vala >= 0.50)
#if FIXED_APPSRC_PUSH_BUFFER_IN_VAPI
recv_rtp.push_buffer((owned) buffer);
#else
Gst.FlowReturn ret;
GLib.Signal.emit_by_name(recv_rtp, "push-buffer", buffer, out ret);
#endif
}
}
@ -315,7 +325,14 @@ public class Dino.Plugins.Rtp.Stream : Xmpp.Xep.JingleRtp.Stream {
}
}
if (push_recv_data) {
recv_rtcp.push_buffer(new Gst.Buffer.wrapped((owned) data));
Gst.Buffer buffer = new Gst.Buffer.wrapped((owned) data);
// See above
#if FIXED_APPSRC_PUSH_BUFFER_IN_VAPI
recv_rtcp.push_buffer((owned) buffer);
#else
Gst.FlowReturn ret;
GLib.Signal.emit_by_name(recv_rtcp, "push-buffer", buffer, out ret);
#endif
}
}