From c8700b44f492a9034f8013f330a04c2c36f2124b Mon Sep 17 00:00:00 2001
From: eerielili <lionel@les-miquelots.net>
Date: Sat, 2 Mar 2024 12:27:44 +0000
Subject: [PATCH] Fix poor contrast of highlight in search results with dark
 theme (#1557)

- fixes #1308
---
 main/src/ui/global_search.vala | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/main/src/ui/global_search.vala b/main/src/ui/global_search.vala
index 6872f631..2fb31a90 100644
--- a/main/src/ui/global_search.vala
+++ b/main/src/ui/global_search.vala
@@ -260,7 +260,8 @@ public class GlobalSearch {
             for (; match_info.matches(); match_info.next()) {
                 int start, end;
                 match_info.fetch_pos(0, out start, out end);
-                markup_text += Markup.escape_text(text[last_end:start]) + "<span bgcolor=\"yellow\">" + Markup.escape_text(text[start:end]) + "</span>";
+                string themed_span = Util.is_dark_theme(label) ? "<span color=\"black\" bgcolor=\"yellow\">" : "<span bgcolor=\"yellow\">";
+                markup_text += Markup.escape_text(text[last_end:start]) + themed_span + Markup.escape_text(text[start:end]) + "</span>";
                 last_end = end;
             }
             markup_text += Markup.escape_text(text[last_end:text.length]);