From 73c0263f35a73b68d20d299ee7fe8c37b9a6ffeb Mon Sep 17 00:00:00 2001 From: fiaxh Date: Fri, 13 Jan 2023 11:23:09 +0100 Subject: [PATCH] Add debug outputs to summarize_whitespaces_to_space and don't assert_not_reached related #1335 --- libdino/src/service/content_item_store.vala | 5 +++++ main/src/ui/util/helper.vala | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libdino/src/service/content_item_store.vala b/libdino/src/service/content_item_store.vala index b3e32cf4..c3d9d006 100644 --- a/libdino/src/service/content_item_store.vala +++ b/libdino/src/service/content_item_store.vala @@ -121,6 +121,8 @@ public class ContentItemStore : StreamInteractionModule, Object { Message? message = get_message_for_content_item(conversation, content_item); if (message == null) return null; + if (message.edit_to != null) return message.edit_to; + if (conversation.type_ == Conversation.Type.CHAT) { return message.stanza_id; } else { @@ -131,6 +133,9 @@ public class ContentItemStore : StreamInteractionModule, Object { public Jid? get_message_sender_for_content_item(Conversation conversation, ContentItem content_item) { Message? message = get_message_for_content_item(conversation, content_item); if (message == null) return null; + + // No need to look at edit_to, because it's the same sender JID. + return message.from; } diff --git a/main/src/ui/util/helper.vala b/main/src/ui/util/helper.vala index 58614bb8..ecf0ab25 100644 --- a/main/src/ui/util/helper.vala +++ b/main/src/ui/util/helper.vala @@ -419,7 +419,8 @@ public string summarize_whitespaces_to_space(string s) { try { return (/\s+/).replace_literal(s, -1, 0, " "); } catch (RegexError e) { - assert_not_reached(); + critical("RegexError when summarizing whitespaces in '%s': %s", s, e.message); + return s; } }