anotherim/anotherim-desktop
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Remove Gst.deinit (proactive bug fix)

Browse source 
Gst.deinit caused the Dino proces to linger in the background when I
tried using Gst in the phone ringer plugin. My reasoning for leaving it
out even though Gst is not in use anymore in the ringer plugin is that
this is a nasty bug that might crop up again in the future when someone
tries to do anything else at all with Gst.

I did the following things:

- checked this https://gstreamer.freedesktop.org/documentation/gstreamer/gst.html#gst_deinit
- tested that Dino works without the Gst.deinit
- tried looking for a specific reason for the deinit with git log -L 276,+10 -- plugins/rtp/src/plugin.vala

I didn't find anything so this made me conclude that it is better to
leave it out.
This commit is contained in:
emil 2022-05-18 15:45:21 +02:00 committed by Stanislav Malishevskiy
parent 1a73e9d53d
commit 734e1503c7
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
plugins/rtp/src/plugin.vala
View file

@ -276,7 +276,6 @@ public class Dino.Plugins.Rtp.Plugin : RootInterface, VideoCallPlugin, Object {
device_monitor.stop(); device_monitor.stop();
} }
destroy_call_pipe(); destroy_call_pipe();
Gst.deinit();
} }
public bool supports(string? media) { public bool supports(string? media) {