From 45b300d2a3599cb1e1faa9714b6cdbb2cb932116 Mon Sep 17 00:00:00 2001
From: emil <emil@dekeyser.xyz>
Date: Wed, 18 May 2022 15:45:21 +0200
Subject: [PATCH] Remove Gst.deinit (proactive bug fix)

Gst.deinit caused the Dino proces to linger in the background when I
tried using Gst in the phone ringer plugin. My reasoning for leaving it
out even though Gst is not in use anymore in the ringer plugin is that
this is a nasty bug that might crop up again in the future when someone
tries to do anything else at all with Gst.

I did the following things:

- checked this https://gstreamer.freedesktop.org/documentation/gstreamer/gst.html#gst_deinit
- tested that Dino works without the Gst.deinit
- tried looking for a specific reason for the deinit with git log -L 276,+10 -- plugins/rtp/src/plugin.vala

I didn't find anything so this made me conclude that it is better to
leave it out.
---
 plugins/rtp/src/plugin.vala | 1 -
 1 file changed, 1 deletion(-)

diff --git a/plugins/rtp/src/plugin.vala b/plugins/rtp/src/plugin.vala
index 514ffdea..5996910f 100644
--- a/plugins/rtp/src/plugin.vala
+++ b/plugins/rtp/src/plugin.vala
@@ -278,7 +278,6 @@ public class Dino.Plugins.Rtp.Plugin : RootInterface, VideoCallPlugin, Object {
             device_monitor.stop();
         }
         destroy_call_pipe();
-        Gst.deinit();
     }
 
     public bool supports(string? media) {